-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove empty lines and rulesets from bundled theme stylesheets #5477
Remove empty lines and rulesets from bundled theme stylesheets #5477
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
@@ -846,9 +846,9 @@ ul.wp-block-archives, | |||
} | |||
} | |||
|
|||
/* Add style for galleries in classic-editor block */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this comment could just be removed, it seems miss placed since the next code block is not for the galleries in the classic editor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing the comment entirely could be good since it's still under the Classic Editor section.
WordPress/twentynineteen@0064cd5 added the styles, copying the comment from the next ruleset (which was removed before version 1.0). If it is worth having a comment for the blockquote
styles, the new explanation could come from the commit message: "Adjust blockquote styles within the classic editor block"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed it.
Committed in r58290 |
/* */
format to single-line//
format, and those do not appear in the compiled stylesheet.Props: ravipatel, viralsampat
Trac 59493
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.