Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove empty lines and rulesets from bundled theme stylesheets #5477

Closed

Conversation

sabernhardt
Copy link

  • Removes empty CSS rulesets in Twenty Ten, Twenty Eleven, Twenty Twelve and Twenty Fourteen.
  • Removes empty lines within rulesets in Twenty Seventeen and Twenty Twenty-One.
  • Rearranges some comments in the SCSS files for Twenty Nineteen so they do not create rulesets without properties.
  • Switches some of Twenty Twenty-One's comments from multi-line /* */ format to single-line // format, and those do not appear in the compiled stylesheet.

Props: ravipatel, viralsampat

Trac 59493


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Copy link

github-actions bot commented Apr 4, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props sabernhardt, poena.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

github-actions bot commented Apr 5, 2024

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@@ -846,9 +846,9 @@ ul.wp-block-archives,
}
}

/* Add style for galleries in classic-editor block */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this comment could just be removed, it seems miss placed since the next code block is not for the galleries in the classic editor.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the comment entirely could be good since it's still under the Classic Editor section.

WordPress/twentynineteen@0064cd5 added the styles, copying the comment from the next ruleset (which was removed before version 1.0). If it is worth having a comment for the blockquote styles, the new explanation could come from the commit message: "Adjust blockquote styles within the classic editor block"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed it.

@sabernhardt
Copy link
Author

Committed in r58290

@sabernhardt sabernhardt deleted the bundled-themes-empty-css branch July 16, 2024 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants